| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Yeb Havinga <yebhavinga(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix for seg picksplit function |
| Date: | 2010-11-05 16:15:55 |
| Message-ID: | AANLkTinderiVZ11MnSMVDpgr3Em5dJTQfVO0BhO2ULTP@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Yeb,
Thank you for review and code refactoring.
PS: when comparing with gbt_num_picksplit, I noticed that that one does not
> update v->spl_ldatum and spl_rdatum to the union datums, but initializes
> these to 0 at the beginning and never seems to update them. Not sure if this
> is a problem since the num_picksplit stuff seems to work well.
>
Actually gbt_num_picksplit updates v->spl_ldatum and spl_rdatum
inside gbt_num_bin_union function.
----
With best regards,
Alexander Korotkov.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dimitri Fontaine | 2010-11-05 16:16:37 | Re: ALTER OBJECT any_name SET SCHEMA name |
| Previous Message | Alvaro Herrera | 2010-11-05 16:10:20 | Re: why does plperl cache functions using just a bool for is_trigger |