Re: PS display and standby query conflict

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PS display and standby query conflict
Date: 2010-12-13 03:06:01
Message-ID: AANLkTindMj7ANG66sh586t8HM0_ddM+g83FxPOUTqMWb@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 11, 2010 at 11:28 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> This problem happens because ResolveRecoveryConflictWithVirtualXIDs
>> resets PS display for each read-only transactions that recovery
>> waits for. Why do we need to reset that each time even though
>> the conflict has not been resolved yet? The attached patch
>> suppresses such a needless reset. Comments?
>
> The reset occurs at most each 500ms, so not much problem there.
>
> But if it annoys you, it seems OK to change it. Don't see a reason to backpatch though?

I think that It's worth backpatch to prevent users who observe the
occurrence of the query conflicts carefully for testing 9.0 from
getting confusing.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Boley 2010-12-13 03:10:44 Re: proposal : cross-column stats
Previous Message Kevin Grittner 2010-12-13 02:58:46 Re: ALTER TABLE ... ADD FOREIGN KEY ... NOT ENFORCED