From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Kris Jurka <books(at)ejurka(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Matthew Wakeling <matthew(at)flymine(dot)org>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Maciek Sakrejda <msakrejda(at)truviso(dot)com>, Samuel Gendler <sgendler(at)ideasculptor(dot)com>, pgsql-jdbc(at)postgresql(dot)org |
Subject: | Re: [HACKERS] Trouble with COPY IN |
Date: | 2010-07-23 00:55:13 |
Message-ID: | AANLkTincY8oaXCvKL4bmDb3VEOj6oSXY3SHX9BYF=maA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-jdbc |
On Thu, Jul 22, 2010 at 5:34 PM, Kris Jurka <books(at)ejurka(dot)com> wrote:
> Per discussion and investigation on the -jdbc list, the server appears to
> violate the frontend/backend protocol when binary copy data is sent to the
> server. Upon receiving the binary copy end of data marker (a -1 field
> count), the server immediately responds with CommandComplete and
> ReadyForQuery without waiting for the frontend to issue CopyDone or
> CopyFail. This confuses the JDBC driver as it doesn't think the command
> sequence should have finished yet.
>
> Attached is a patch to make the server continue to consume protocol data
> until instructed to stop by the client in the same way as copying text data
> to the server currently works.
>
> http://www.postgresql.org/docs/8.4/static/protocol-flow.html#PROTOCOL-COPY
> http://www.postgresql.org/docs/8.4/static/sql-copy.html
>
> Kris Jurka
I guess the obvious question is whether we shouldn't instead change
the docs to match the behavior. I suspect there's almost no chance
we'd consider back-patching a change of this type, since it is a clear
behavior change. And even if we did, there would still be people
running servers with the old behavior with which JDBC and other
drivers would have to cope. Having two different behaviors might be
worse than the status quo.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | KaiGai Kohei | 2010-07-23 00:58:11 | Re: security label support, part.2 |
Previous Message | Robert Haas | 2010-07-23 00:31:41 | Re: review: psql: edit function, show function commands patch |
From | Date | Subject | |
---|---|---|---|
Next Message | Matthew Wakeling | 2010-07-23 09:33:27 | Re: Trouble with COPY IN |
Previous Message | Kris Jurka | 2010-07-22 21:34:08 | Re: Trouble with COPY IN |