From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Yeb Havinga <yebhavinga(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Sync Rep v19 |
Date: | 2011-03-28 19:03:45 |
Message-ID: | AANLkTinXZoVH_vMtow6A+XQNi7MGMs=_BT96ZBcqq8pt@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Mar 24, 2011 at 11:53 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Thu, Mar 24, 2011 at 8:34 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> On Thu, Mar 24, 2011 at 11:17 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> On Wed, Mar 23, 2011 at 5:53 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>>>>> Do you still want to work up a patch for this? If so, I can review.
>>>>
>>>> Sure. Will do.
>>>
>>> The attached patch allows standby servers to connect during smart shutdown
>>> in order to wake up backends waiting for sync rep.
>>
>> I think that is possibly OK, but the big problem is the lack of a
>> clear set of comments about how the states are supposed to interact
>> that allow these changes to be validated.
>>
>> That state isn't down to you, but I think we need that clear so this
>> change is more obviously correct than it is now.
>
> src/backend/replication/README needs to be updated to make that clear?
Not sure where we'd put them.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Yeb Havinga | 2011-03-28 19:24:37 | Re: Additional options for Sync Replication |
Previous Message | Alexander Korotkov | 2011-03-28 18:51:55 | Re: Proposal: q-gram GIN and GiST indexes |