| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Custom code int(32|64) => text conversions out of performance reasons |
| Date: | 2010-11-20 17:18:32 |
| Message-ID: | AANLkTinUSOgBfxEfNXCORW0hpynt1qLR0Cdes03z4nUZ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Nov 20, 2010 at 10:38 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> The trouble with that approach is that you have to depend on the
> direction of rounding for negative quotients. Which was unspecified
> before C99, and it's precisely pre-C99 compilers that are posing a
> hazard to the current coding.
Interesting. I wondered whether there might be compilers out there
that handled that inconsistently, but then I thought I was probably
being paranoid.
> Likewise for the int64 case, which BTW is no safer for pre-C99 compilers
> than it was yesterday: LL is not the portable way to write int64
> constants.
Gah. I wish we had some documentation of this stuff.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-11-20 17:34:04 | Re: [PATCH] Custom code int(32|64) => text conversions out of performance reasons |
| Previous Message | Tom Lane | 2010-11-20 15:38:32 | Re: [PATCH] Custom code int(32|64) => text conversions out of performance reasons |