Re: Tab completion for view triggers in psql

On Sun, Nov 21, 2010 at 1:07 PM, David Fetter <david(at)fetter(dot)org> wrote:
> On Fri, Oct 29, 2010 at 08:33:00AM -0700, David Fetter wrote:
>> On Tue, Oct 26, 2010 at 11:55:07AM +0900, Itagaki Takahiro wrote:
>> > On Tue, Oct 26, 2010 at 11:34 AM, David Fetter <david(at)fetter(dot)org> wrote:
>> > >> Do we need to 'add' it?
>> > > Possibly.  My understanding is that it couldn't really replace it.
>> >
>> > Ah, I see.  I was wrong.  We can have modification privileges for
>> > views even if they have no INSTEAD OF triggers.
>>
>> Right.
>>
>> > So, I think your original patch is the best solution.  We could use
>> > has_table_privilege() additionally, but we need to consider any
>> > other places if we use it.  For example, DROP privileges, etc.
>>
>> That seems like a matter for a separate patch.  Looking this over, I
>> found I'd created a query that can never get used, so please find
>> enclosed the next version of the patch :)
>
> Could someone please commit this? :)

Eh... was there some reason you didn't add it to the CommitFest app?
Because that's what I work from.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company