From: | Joel Jacobson <joel(at)gluefinance(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Jim Nasby <jim(at)nasby(dot)net>, Herrera Alvaro <alvherre(at)commandprompt(dot)com>, pgsql-hackers Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Bug in pg_describe_object |
Date: | 2011-01-11 07:34:46 |
Message-ID: | AANLkTinQwNtrJ7kcEp7htZvdz06O2ZzBLWwjqzYmBbYY@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2011/1/11 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> It would make dependency error messages significantly longer and less
> readable. Quite aside from the point at hand here, we elide schema
> names in many cases (and it looks like there are some code paths where
> getObjectDescription never bothers to print them at all). Another issue
> that might make it interesting to try to use the output for purposes
> other than human-readable descriptions is that we localize all the
> phrases involved.
>
> My point is that this isn't a bug fix, it's more like moving the
> goalposts on what getObjectDescription is supposed to do. And I'm not
> even very sure where they're being moved to. I haven't seen a
> specification for an intended use of pg_describe_object for which its
> existing behavior would be unsatisfactory.
Thanks for some good arguments. I now agree with you it would be a bit
counter productive to change the existing pg_describe_object.
Due to the localization of the phrases and the lack of mandatory
namespace inclusion, you lose the comparison ability anyway.
I instead propose we introduce a new function named
pg_get_object_unique_identifier( classid oid, objid oid, objsubid
integer ) returns text.
The name would make sense since we already have a
pg_get_function_identity_arguments( func_oid ), for a similar purpose
but solely for functions.
--
Best regards,
Joel Jacobson
Glue Finance
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2011-01-11 08:44:28 | Re: Streaming base backups |
Previous Message | Tatsuo Ishii | 2011-01-11 06:30:26 | Re: Error code for "terminating connection due to conflict with recovery" |