Re: Complier warnings on mingw gcc 4.5.0

On Mon, Dec 13, 2010 at 22:29, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 12/13/2010 01:12 PM, Tom Lane wrote:
>>
>> Andrew Dunstan<andrew(at)dunslane(dot)net>  writes:
>>>
>>> On 12/13/2010 12:01 PM, Tom Lane wrote:
>>>>
>>>> It smells a little bit like an optimization bug.  Does dialing down to
>>>> -O0 make it go away?
>>>
>>> Sadly, no. I'm testing downgrading the compiler now.
>>
>> Mph.  FWIW, I see that my last build of Postgres for Fedora 14 would
>> have been with gcc 4.5.1, because that's what F14 is shipping.  And
>> that passed its regression tests on at least x86 and x86_64.  Maybe
>> you should pester the mingw folk for a compiler update.
>>
>>
>
> Further digging shows some weirdness. This doesn't appear to be
> compiler-related. I've rolled back all the way to gcc 3.5. It is triggered
> by the following line in pg_regress.c, commenting out of which causes the
> problem to go away (although of course it causes the regression tests to
> fail):
>
>    putenv(new_pgoptions);

Take a look at 741e4ad7de9e0069533d90efdd5b1fc9f3a64c81.

If you enable that codepath to run on mingw, does it fix it? (it's
msvc only now)

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/