Re: error in last pgadmin git version

In fact, I am able to reproduce the same on my side with the latest code
(included Dave's last checked-in).
One thing - I have noticed in this case.
It will reproducible with the table, which does not Primary Key.
i.e. CREATE TABLE test(c1 integer, c2 integer);

And, crash is in the "Primary Key Property" dialog. So, I doubt - it has
something to do with the Dave's check-ins.
This is the back-trace, I found:
*#0 0x0012d422 in __kernel_vsyscall ()*
*#1 0x011b3230 in raise (sig=5) at
../nptl/sysdeps/unix/sysv/linux/pt-raise.c:42*
*#2 0x00da87f5 in wxTrap () at ./src/common/appbase.cpp:674*
*#3 0x00a6998c in wxGUIAppTraits::ShowAssertDialog (this=0x8888120,
msg=...) at ./src/gtk/utilsgtk.cpp:392*
*#4 0x00da8c94 in ShowAssertDialog (szFile=0xc15e4c
L"./src/common/ctrlsub.cpp", nLine=170, szFunc=0x912888c L"GetClientData", *
* szCond=0xc16170 L"m_clientDataItemsType == wxClientData_Void",
szMsg=0xc160c8 L"this window doesn't have void client data", *
* traits=0x8888120) at ./src/common/appbase.cpp:836*
*#5 0x00da7ff4 in wxAppConsole::OnAssertFailure (this=0x8833a00,
file=0xc15e4c L"./src/common/ctrlsub.cpp", line=170, *
* func=0x912888c L"GetClientData", cond=0xc16170 L"m_clientDataItemsType
== wxClientData_Void", *
* msg=0xc160c8 L"this window doesn't have void client data") at
./src/common/appbase.cpp:445*
*#6 0x00a3acf9 in wxApp::OnAssertFailure (this=0x8833a00, file=0xc15e4c
L"./src/common/ctrlsub.cpp", line=170, *
* func=0x912888c L"GetClientData", cond=0xc16170 L"m_clientDataItemsType
== wxClientData_Void", *
* msg=0xc160c8 L"this window doesn't have void client data") at
./src/gtk/app.cpp:556*
*#7 0x00da88de in wxOnAssert (szFile=0xc15e4c L"./src/common/ctrlsub.cpp",
nLine=170, szFunc=0xc16291 "GetClientData", *
* szCond=0xc16170 L"m_clientDataItemsType == wxClientData_Void",
szMsg=0xc160c8 L"this window doesn't have void client data")*
* at ./src/common/appbase.cpp:711*
*#8 0x00b12419 in wxItemContainer::GetClientData (this=0x90e738c, n=0) at
./src/common/ctrlsub.cpp:170*
*#9 0x080b9902 in wxComboBox::GetClientData (this=0x90e7238, n=0) at
/usr/local/include/wx-2.8/wx/gtk/combobox.h:137*
*#10 0x080b887f in ctlComboBoxFix::GetOIDKey (this=0x90e7238, sel=0) at
./ctl/ctlComboBox.cpp:103*
*#11 0x0814a8e8 in dlgIndexConstraint::OnSelectComboCol (this=0xbfffde08,
ev=...) at ./dlg/dlgIndexConstraint.cpp:381*
*#12 0x00da7cca in wxAppConsole::HandleEvent (this=0x8833a00,
handler=0xbfffde08, *
* func=0x814a780 <dlgIndexConstraint::OnSelectComboCol(wxCommandEvent&)>,
event=...) at ./src/common/appbase.cpp:322*
*#13 0x00e4ade5 in wxEvtHandler::ProcessEventIfMatches (entry=...,
handler=0xbfffde08, event=...) at ./src/common/event.cpp:1231*
*#14 0x00e49d91 in wxEventHashTable::HandleEvent (this=0x87a7040, event=...,
self=0xbfffde08) at ./src/common/event.cpp:906*
*...*

It is actually an assertion, not crash.
But, debug version of pgadmin prompts for this and get crashes after this
assertion.
As cbColumns (ctComboBoxFix) in dlgIndexConstraint has no Client Data for
the current selection, it throws assertion. :-(

*--**
**Thanks & Regards,**

**Ashesh Vashi**
**EnterpriseDB INDIA:* Enterprise Postgres Company<http://www.enterprisedb.com>

On Thu, Aug 19, 2010 at 3:02 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info>wrote:

> Le 19/08/2010 11:29, Dave Page a écrit :
> > On Thu, Aug 19, 2010 at 9:36 AM, Ashesh Vashi
> > <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> >> I am able to reproduce it (it is reproducible with an index constraints
> in
> >> the table.)
> >> And, also found one more crash while working on it.
> >> Steps to reproduce:
> >> - Create a table without any constraint
> >> i.e. CREATE TABLE xyz(c1 integer, c2 character varying);
> >> - Open Table Properties for the 'xyz' table.
> >> - Go to 'Constraints' tab
> >> - Click 'Add' button
> >> - It will open the 'New primary key' dialog
> >> - Go to 'Columns' tab
> >> - Select any column from the column combo-box and Boom... (Crashed).
> >
> > Works fine here. Can you debug at your end?
> >
>
> Probably Ashesh wasn't using your patch when he did his test?
>
>
> --
> Guillaume
> http://www.postgresql.fr
> http://dalibo.com
>