From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins. |
Date: | 2010-12-31 05:09:56 |
Message-ID: | AANLkTinNNV6kr7kmVtoUiQ0SQYxY1HdCk98P9yReQvMJ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Thu, Dec 30, 2010 at 9:55 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> This is cool, but on first blush your changes to
>>> add_paths_to_joinrel() appear to be total nonsense. I think the
>>> problem is that have_nonmergeable_clause is really a misnomer - it's
>>> not clear until you read through the whole diff that this won't get
>>> set for inner/left joins.
>
>> Yeah, I wasn't totally satisfied with that variable name either.
>> Do you have a better idea?
>
> On reflection, how about inverting the flag's value and calling it
> mergejoin_allowed or some such?
Yeah, that's better.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-12-31 17:00:07 | pgsql: Invert and rename flag variable to improve code readability. |
Previous Message | Tom Lane | 2010-12-31 03:13:09 | pgsql: Move symbols for ExecMergeJoin's state machine into nodeMergejoi |