Re: recovery getting interrupted is not so unusual as it used to be

From: Greg Stark <gsstark(at)mit(dot)edu>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Florian Pflug <fgp(at)phlo(dot)org>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: recovery getting interrupted is not so unusual as it used to be
Date: 2010-06-05 02:04:53
Message-ID: AANLkTinDQXp4fPfLq_zeDjAw-GyKsbN9CqWWKC3s5_38@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jun 5, 2010 at 2:20 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I've tried to keep this as similar as possible to the existing message while making it less ambiguous about cause and effect.
>>
>> "If this has occurred more than once corrupt data might be the cause and you might need to choose an earlier recovery target".

> If the database system is exiting unexpectedly during archive
> recovery, some data might be corrupted and you might need to choose an
> earlier recovery target.

I think you've missed the key addition in Florian's suggestions. The
"might be the cause" tips the user off to what's going on. Your
statement is just as ambiguous as the original message in that it
could be (and usually would be) read as saying that the interruption
of recovery could cause the corruption.

I would probably write it as "If this is happening repeatedly it might
be caused by corrupt data. Try choosing an earlier recovery target
prior to the corruption.". Florian's phrasing seemed ok to me too
though.

--
greg

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joseph Adams 2010-06-05 02:07:12 Re: functional call named notation clashes with SQL feature
Previous Message Joseph Adams 2010-06-05 01:55:56 Re: functional call named notation clashes with SQL feature