From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | obsolete comments in xlog.c |
Date: | 2010-06-02 07:39:47 |
Message-ID: | AANLkTimsxfwI7txMle8vOCQj1KZCzUxMwNf_eltLB67e@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
I found some obsolete comments in xlog.c, which are related to
recently-deleted variable "fromArchive".
diff --git a/src/backend/access/transam/xlog.c
b/src/backend/access/transam/xlog.c
index c886571..65675b9 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -2609,8 +2609,8 @@ XLogFileOpen(uint32 log, uint32 seg)
/*
* Open a logfile segment for reading (during recovery).
*
- * If fromArchive is true, the segment is retrieved from archive, otherwise
- * it's read from pg_xlog.
+ * If source = XLOG_FROM_ARCHIVE, the segment is retrieved from archive.
+ * If source = XLOG_FROM_PG_XLOG, it's read from pg_xlog.
*/
static int
XLogFileRead(uint32 log, uint32 seg, int emode, TimeLineID tli,
@@ -2673,8 +2673,6 @@ XLogFileRead(uint32 log, uint32 seg, int emode,
TimeLineID tli,
* Open a logfile segment for reading (during recovery).
*
* This version searches for the segment with any TLI listed in expectedTLIs.
- * If not in StandbyMode and fromArchive is true, the segment is also
- * searched in pg_xlog if not found in archive.
*/
static int
XLogFileReadAnyTLI(uint32 log, uint32 seg, int emode, int sources)
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2010-06-02 09:25:20 | Re: Synchronization levels in SR |
Previous Message | Greg Smith | 2010-06-02 07:22:42 | Re: Synchronization levels in SR |