Re: [pgAdmin III] #209: "Connect to Server" dialog buggy

On Mon, Jul 12, 2010 at 11:39 AM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi Dave,
> Please find the patch for the same.

Thanks. This looks good to me following some quick testing, but I
uncovered some other issues - could you look at them please?

- We seem to stop populating the server combo box as soon as we find
the one we're currently connected to. This happens at ~ line 286 in
dlgSelectConnection.cpp, where we set foundServer = true. I can't see
why we do this, but it seems fairly deliberate. Any guesses? Should we
just remove that?

- It seems like we ignore sslmode when we create new connections. We
need to honour the server config.

Note that I haven't tested to ensure this doesn't break anything in
command line startup mode (eg. with -q). Can you please ensure this
mode is unaffected?

Thanks.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company