From: | Josh Kupershmidt <schmiddy(at)gmail(dot)com> |
---|---|
To: | David Fetter <david(at)fetter(dot)org> |
Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Tab completion for view triggers in psql |
Date: | 2010-11-25 04:01:28 |
Message-ID: | AANLkTimBydypSJfZKwz+bDYzV-9SRQy-R1s0CZ1ZciAy@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Nov 23, 2010 at 10:21 PM, David Fetter <david(at)fetter(dot)org> wrote:
> Please find attached a patch changing both this and "updateable" to
> "updatable," also per the very handy git grep I just learned about :)
I looked a little more at this patch today. I didn't find any serious
problems, though it would have helped me (and maybe other reviewers)
to have a comprehensive list of the SQL statements which the patch
implements autocompletion for.
Not sure how hard this would be to add in, but the following gets
autocompleted with an INSERT:
CREATE TRIGGER mytrg BEFORE IN[TAB]
while the following doesn't find any autocompletions:
CREATE TRIGGER mytrg BEFORE INSERT OR UP[TAB]
Also, this existed before the patch, but this SQL:
CREATE TRIGGER mytrg INSTEAD OF INSERT ON [TAB]
autocompletes to:
CREATE TRIGGER mytrg INSTEAD OF INSERT ON SET
not sure how that "SET" is getting in there -- some incorrect tab
completion match?
Josh
From | Date | Subject | |
---|---|---|---|
Next Message | KaiGai Kohei | 2010-11-25 05:03:48 | Re: security hooks on object creation |
Previous Message | Robert Haas | 2010-11-25 03:57:31 | Re: Per-column collation, work in progress |