From: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | pgsql-rrreviewers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] reviewers needed! |
Date: | 2011-01-26 18:21:41 |
Message-ID: | AANLkTimBkorS53uD9TSKxhDh3bo+8+YY++8QSTxhqQrV@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-rrreviewers |
Hi!
I can join as an RRR, if its still needed.
--
Ibrar Ahmed
EnterpriseDB Corporation
The Enterprise Postgres Company
On Mon, Jan 17, 2011 at 3:10 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sun, Jan 16, 2011 at 2:30 PM, Andy Colson <andy(at)squeakycode(dot)net> wrote:
>> I reviewed a couple patched, and I added my review to the commitfest page.
>>
>> If I find a problem, its obvious I should mark the patch as "returned with
>> feedback".
>
> Only if it's got sufficiently serious flaws that getting it committed
> during this CommitFest is not practical. If it just needs some
> revision, "Waiting on Author" is the right place.
>
>> But what if I'm happy with it? I'm not a hacker so cannot do C code review,
>> should I leave it alone? Mark it as "ready for committer"?
>
> Yep, that's fine.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> --
> Sent via pgsql-rrreviewers mailing list (pgsql-rrreviewers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-rrreviewers
>
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-01-26 18:32:20 | Re: [COMMITTERS] pgsql: Remove arbitrary ALTER TABLE .. ADD COLUMN restriction. |
Previous Message | Kevin Grittner | 2011-01-26 18:06:13 | Re: SSI, simplified |
From | Date | Subject | |
---|---|---|---|
Next Message | Richard Broersma | 2011-01-26 18:32:36 | Re: [HACKERS] Seeking Mentors for Funded Reviewers |
Previous Message | David E. Wheeler | 2011-01-26 17:45:25 | Re: [HACKERS] Seeking Mentors for Funded Reviewers |