From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Christian Ullrich <chris(at)chrullrich(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: SSPI client authentication in non-Windows builds |
Date: | 2011-01-29 16:15:35 |
Message-ID: | AANLkTim-SOHR9NSABxFEY7Gxbubw2trm3v1VO+07vLxN@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Jan 29, 2011 at 16:22, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Sat, Jan 29, 2011 at 16:21, Christian Ullrich <chris(at)chrullrich(dot)net> wrote:
>> * Magnus Hagander wrote:
>>
>>> However, i think the code path down around the error message is simply
>>> incorrect. That #ifdef spaghetti is pretty hard to parse, but it gives
>>> the wrong error message (we should say it's sspi that's not available
>>> when we have none of the two options) and/or a "duplicate case label"
>>> error, in some combinations of sspi/gssapi existing/notexisting.
>>
>>>
>>>
>>> Attached is an updated version of the patch that passes compiling on
>>> all my systems in different combinations, including msvc. Can you
>>> verify that it still works in your env? (you don't have to retest all
>>> those platforms!)
>>
>> Yes, it works fine, for md5, sspi, and gss authentication methods, tested
>> with MIT 1.4 against Windows 2008R2, PostgreSQL 8.4.4.
>
> Great, thanks!
And applied.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2011-01-29 16:50:19 | REVIEW: Determining client_encoding from client locale |
Previous Message | Bernd Helmle | 2011-01-29 16:09:23 | Re: pg_upgrade fails for non-postgres user |