Re: pgsql: Allow copydir() to be interrupted.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Allow copydir() to be interrupted.
Date: 2010-07-02 13:19:23
Message-ID: AANLkTil_xQP8NuDvmKl80-fX5uvlipmboohws-EXAMu6@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Jul 2, 2010 at 2:13 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Jul 2, 2010 at 8:10 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> Robert Haas wrote:
>>> Log Message:
>>> -----------
>>> Allow copydir() to be interrupted.
>>>
>>
>> This appears to have broken MinGW and Cygwin builds on the buildfarm.
>
> Well, that's not awesome. IM-ing with Magnus now.  I'm wondering if
> this is a link-ordering problem of some kind.

We've seen something like this before, but I don't recall what it was.
It's probably something getting resolved too early when it's built
into libpgport_srv.a. That would explain why it's working fine on MSVC
- we don't actually bother building a server-side .lib there, we just
link the object files directly into postgres.exe. (We do build the
library for client side, of course, since it's used in many different
binaries)

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-07-02 13:30:06 Re: pgsql: Allow copydir() to be interrupted.
Previous Message Robert Haas 2010-07-02 13:13:37 Re: pgsql: Allow copydir() to be interrupted.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-07-02 13:30:06 Re: pgsql: Allow copydir() to be interrupted.
Previous Message Robert Haas 2010-07-02 13:13:37 Re: pgsql: Allow copydir() to be interrupted.