From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Greg Sabino Mullane <greg(at)turnstep(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: Invalid YAML output from EXPLAIN |
Date: | 2010-06-07 15:17:55 |
Message-ID: | AANLkTilEtgAOJT26h4kK4LtCghh2-V2xeBeIlMUjqRtt@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On 7 June 2010 15:56, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Greg Sabino Mullane" <greg(at)turnstep(dot)com> writes:
>> I don't think the above would be particularly hard to implement myself,
>> but if it becomes a really big deal, we can certainly punt by simply
>> quoting anything containing an indicator (the special characters above).
>
> I would go with that. The quoting rules you proposed previously seem
> way too complicated --- meaning potentially buggy, and even if they're
> not buggy, the behavior would seem unpredictable to most users.
>
Well actually it's not just everything containing a special character,
it's also anything with leading or trailing whitespace, and empty
strings (not sure that can ever happen in practice).
It's because of the potential for bugs in this area, that I'd propose
just quoting everything (except numeric values) as in my original
patch.
Regards,
Dean
From | Date | Subject | |
---|---|---|---|
Next Message | Piergiorgio Buongiovanni | 2010-06-07 15:34:57 | BUG #5491: Queries performing slowly |
Previous Message | Andy Balholm | 2010-06-07 15:16:36 | Re: BUG #5490: INSERT doesn't force cast from text to timestamp |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-06-07 15:42:05 | Re: SR slaves and .pgpass |
Previous Message | Tom Lane | 2010-06-07 14:56:40 | Re: Invalid YAML output from EXPLAIN |