Re: REPLICATION privilege and shutdown

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: REPLICATION privilege and shutdown
Date: 2011-01-20 09:59:17
Message-ID: AANLkTikwd06bFGyfmNSdQVN-sHAPNANMnnuYD7L3Ns+L@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 20, 2011 at 6:50 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> I think we need to consider the situation after the "multiple streaming base
> backups" patch goes in. After that we can change pg_stop_backup() so that
> you need superuser privileges to run it again - replication privileges is
> enough to do a streaming base backup, but that no longer interferes with the
> pg_start/stop_backup() admin functions.

Fair enough.

> At the moment, a streaming base backup and manual pg_start/stop_backup() use
> the same machinery, so it's possible e.g to run pg_stop_backup() while a
> streaming base backup is running, causing it to fail at the end. Or worse,
> you can run pg_stop_backup()+pg_start_backup(), and the streaming base
> backup will seemingly succeed, but the produced backup is potentially
> corrupt.
>
> The multiple base backups patch will fix that too.

OK.

BTW, I found this behavior when I read your patch ;)

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Csaba Nagy 2011-01-20 10:05:01 Re: estimating # of distinct values
Previous Message Magnus Hagander 2011-01-20 09:54:48 Re: REPLICATION privilege and shutdown