Re: Invalid YAML output from EXPLAIN

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: Invalid YAML output from EXPLAIN
Date: 2010-06-09 12:46:09
Message-ID: AANLkTikuFJlolmv_Hcgpxsj5mQybd6nf2C_GoJKjqdkV@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 9 June 2010 03:48, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> please test.

Well your patch definitely fixes my original bug, and AFAICT always
produces valid YAML output now. I've only found one case where a
particular parser has difficulty parsing the output, and you'd have to
write a pretty perverse query to hit that case.

So that just leaves this sort of thing:

explain (format yaml) select * from foo as "123";
QUERY PLAN
-------------------------
- Plan: +
Node Type: Seq Scan+
Relation Name: foo +
Alias: 123 +
Startup Cost: 0.00 +
Total Cost: 23.10 +
Plan Rows: 1310 +
Plan Width: 32
(1 row)

Does anyone care that Alias will sometimes be a string, and sometimes a number?

ITSM that, since postgresql knows that it's a string, it ought to
output something that parsers can unambiguously treat as a string too.

But this is also a pretty obscure case that probably only someone
deliberately trying to be awkward would do (which is me, with my
tester hat on :-)).

Regards,
Dean

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Craig Ringer 2010-06-09 13:03:54 Re: BUG #5475: Problem during Instalation
Previous Message Dean Rasheed 2010-06-09 11:43:42 Re: Invalid YAML output from EXPLAIN

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2010-06-09 13:06:10 Re: hstore ==> and deprecate =>
Previous Message Leonardo F 2010-06-09 12:32:50 Re: Git: Unable to get pack file