Re: Fix for cube picksplit function

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, greg(at)turnstep(dot)com
Subject: Re: Fix for cube picksplit function
Date: 2010-11-15 02:34:23
Message-ID: AANLkTikroS6akLbKQNrqiU9eEz7etCFhH=3yJ5zovqg3@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 29, 2010 at 2:59 PM, Alexander Korotkov
<aekorotkov(at)gmail(dot)com> wrote:
> Gist picksplit method implementation in cube contrib module contains a bug
> in Guttman's split algorithm implementation. It was mentioned before but it
> is still not fixed yet. Current implementation doesn't cause incorrect
> behavior, but index becomes very bad, because each index scan require to
> read significant part of index.

It looks to me like this can be safely back-patched, because it
doesn't affect the contents of index entries already on disk, just the
manner in which we construct new ones.

So I've committed this and back-patched it all the way back to 8.1.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-11-15 02:37:13 Re: Refactoring the Type System
Previous Message Greg Stark 2010-11-15 02:33:27 Explain analyze getrusage tracking