| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Greg Smith <greg(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: auto-sizing wal_buffers |
| Date: | 2011-01-15 08:02:30 |
| Message-ID: | AANLkTikoUWemGmAmNGHXW8QQoo45sLxzr-aU=rUwshba@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 15, 2011 at 3:51 PM, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
> Agreed on both fronts. Attached patch does the magic. Also available in
> branch "walbuffers" from git://github.com/greg2ndQuadrant/postgres.git
+int XLOGbuffersMin = 8;
XLOGbuffersMin is a fixed value. I think that defining it as a macro
rather than a variable seems better.
+ if (XLOGbuffers > 2048)
+ XLOGbuffers = 2048;
Using "XLOG_SEG_SIZE/XLOG_BLCKSZ" rather than 2048 seems
better.
+#wal_buffers = -1 # min 32kB, -1 sets based on shared_buffers
Typo: s/32kB/64kB
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2011-01-15 09:47:56 | Re: We need to log aborted autovacuums |
| Previous Message | David E. Wheeler | 2011-01-15 07:37:31 | Re: Fixing GIN for empty/null/full-scan cases |