From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <heikki(at)postgresql(dot)org> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: In walsender, don't sleep if there's outstanding WAL waiting to |
Date: | 2010-05-31 10:03:44 |
Message-ID: | AANLkTikoPtDuL8vefTRaCXbofp-bpXPXPrmKV_VxURXv@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Hi,
On Thu, May 27, 2010 at 7:21 AM, Heikki Linnakangas
<heikki(at)postgresql(dot)org> wrote:
> Log Message:
> -----------
> In walsender, don't sleep if there's outstanding WAL waiting to be sent,
> otherwise we effectively rate-limit the streaming as pointed out by
> Simon Riggs. Also, send the WAL in smaller chunks, to respond to signals
> more promptly.
>
> Modified Files:
> --------------
> pgsql/src/backend/replication:
> walsender.c (r1.20 -> r1.21)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/replication/walsender.c?r1=1.20&r2=1.21)
This commit seems to have introduced the bug that walsender exits
before sending all the WAL up to shutdown checkpoint record when
smart shutdown is requested.
The attached patch fixes the bug and a tiny typo.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2010-05-31 10:20:28 | Re: [COMMITTERS] pgsql: In walsender, don't sleep if there's outstanding WAL waiting to |
Previous Message | User Itagaki | 2010-05-31 06:07:52 | textsearch-ja - textsearch_senna: Senna doesn't require any locks in |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2010-05-31 10:17:03 | Re: Streaming Replication: Checkpoint_segment and wal_keep_segments on standby |
Previous Message | Heikki Linnakangas | 2010-05-31 09:37:18 | Re: Streaming Replication: Checkpoint_segment and wal_keep_segments on standby |