From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: SQL/MED - file_fdw |
Date: | 2010-12-13 06:31:42 |
Message-ID: | AANLkTiknnyGEFbTehV-pt7+R-EYSK4poAoYzqkJ3-k3y@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Dec 11, 2010 at 05:30, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> On 12/04/2010 11:11 PM, Itagaki Takahiro wrote:
>> One exports the copy functions from the core, and another
>> implements file_fdw using the infrastructure.
>
> Who is actually going to do this split?
I'm working for it :-) I extract those functions from copy.c:
- CopyState BeginCopyFrom(Relation rel, const char *filename,
List *attnamelist, List *options);
- void EndCopyFrom(CopyState cstate);
- bool NextCopyFrom(CopyState cstate,
Datum *values, bool *nulls, Oid *oid);
There was Reset() in file_fdw, but it is not contained in the
patch. It will be added again if required, but I wonder we might
need not only reset but also mark/restore a position in a file.
--
Itagaki Takahiro
Attachment | Content-Type | Size |
---|---|---|
copy_export-20101213.diff | application/octet-stream | 37.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2010-12-13 06:44:13 | pg_archivecleanup should remove WAL files also in pg_xlog? |
Previous Message | Rob Wultsch | 2010-12-13 06:15:34 | Re: unlogged tables |