From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thom Brown <thom(at)linux(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Session timeout on commitfest.postgresql.org |
Date: | 2010-08-10 19:15:24 |
Message-ID: | AANLkTiknkn_-w7AhhshywGTn2QWEM5=__0f44H4E523s@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 10, 2010 at 2:43 PM, Kevin Grittner
<Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> Very nice. I was going to ask to have "Ready for Committer" split
> out to its own section, but with this filtering, it's probably not
> worth the bother. This change will be very nice for CF managers.
Glad you like.
> While we're on the topic of CF app enhancements, I often wished that
> the date of the last change to the "Reviewers" column would show
> underneath the name(s) where the value was not empty and the date
> was later than both the "Last Activity" date and the start of the
> CF. (Either that or count a non-NULL value set into this column as
> a reason to set the current date into "Last Activity", but I like
> the extra date better.)
That seems complex.
> It occasionally seems as though WiP patches are different enough
> that there should be a more systematic was to flag them and count
> them, but I can't think of any concrete way to do that which doesn't
> introduce more problems than it would fix.
I agree that it occasionally seems that way, but it seems hard to get
worked up about it.
> And I still think that a link back to the CommitFest Wiki page might
> prevent the occasional gaff by people new to the application, but
> that assumes they'd follow the link and read up on the process
> before jumping in with entries in the app. The two most common
> issues seem to be putting a URL in the Message-ID field, and putting
> a whole review into the comment text rather than a brief summary and
> a link to a post with the review.
Oh, yeah, I forgot that you asked for this. It's probably a good idea
to work that in somewhere.
> Occasionally people failed to set
> a new status when they should have done after linking in a new patch
> or review.
I remain unconvinced that any tweaking of the system in this area
comes out to a net plus.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2010-08-10 19:25:30 | Re: Session timeout on commitfest.postgresql.org |
Previous Message | David E. Wheeler | 2010-08-10 18:48:53 | Re: string_to_array with an empty input string |