| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Jan Urbański <wulczer(at)wulczer(dot)org> |
| Cc: | Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: gincostestimate |
| Date: | 2010-07-30 18:03:59 |
| Message-ID: | AANLkTiki9N+7gASPdi78BGULYs4ZKJPHZMmj8NpPhMz4@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 30, 2010 at 1:19 PM, Jan Urbański <wulczer(at)wulczer(dot)org> wrote:
> The patch has lots of statements like if ( GinPageIsLeaf(page) ), that is
> with extra space between the outer parenthesis and the condition, which
> AFAIK is not the project style. I guess pgindent fixes that, so it's no big
> deal.
It's better if these get cleaned up. pgindent will fix it eventually,
but the less stuff pgindent has to touch, the less likelihood there is
of breaking outstanding patches when it's run.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-07-30 18:08:19 | Re: reducing NUMERIC size for 9.1 |
| Previous Message | Robert Haas | 2010-07-30 17:42:04 | Re: reducing NUMERIC size for 9.1 |