From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Marti Raudsepp <marti(at)juffo(dot)org>, KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements. |
Date: | 2011-01-17 15:05:31 |
Message-ID: | AANLkTikfO6vgB-Jfvmt_cWGktiwYFFXEhgAQMVf8Hbg_@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jan 17, 2011 at 9:41 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On fre, 2011-01-14 at 18:45 -0500, Robert Haas wrote:
>> On Fri, Jan 14, 2011 at 3:45 PM, Marti Raudsepp <marti(at)juffo(dot)org>
>> wrote:
>> > There's a similar case with CREATE TABLE IF NOT EXISTS, maybe this
>> is
>> > worth covering in an updated patch too?
>> > And if I change that, people might expect the same from DROP X IF
>> EXISTS too?
>>
>> It's far less clear what you'd change those cases to say, and they
>> already emit a NOTICE, so it seems unnecessary.
>
> Maybe instead of the proposed patch, a notice could be added:
>
> NOTICE: existing object was replaced
Well, that would eliminate the backward-compatibility hazard, pretty
much, but it seems noisy. I already find some of these notices to be
unduly informative.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2011-01-17 15:12:33 | Re: Replication logging |
Previous Message | David Fetter | 2011-01-17 15:05:05 | Re: SSI patch version 12 |