From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | Thom Brown <thom(at)linux(dot)com>, pgadmin-support <pgadmin-support(at)postgresql(dot)org> |
Subject: | Re: PgAdmin III 1.12 crazy memory usage |
Date: | 2010-10-07 16:03:42 |
Message-ID: | AANLkTikcfUezXGvRH8byVFL4sT+=8ZE9WPaBsnzf811S@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-support |
On Thu, Oct 7, 2010 at 4:59 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 07/10/2010 13:56, Dave Page a écrit :
>> On Tue, Oct 5, 2010 at 11:03 AM, Thom Brown <thom(at)linux(dot)com> wrote:
>>> Okay, I've tried reproducing it by asking it to show the edit view
>>> without restricting the number of results, but seems to be fine. But
>>> if I open with limited to 100, then change it to "no limit", refresh
>>> and close, the query still appears to be running on the server. It
>>> shows "pgAdmin III - Edit Grid" as the process running the query too,
>>> and there's still lots of I/O on the machine. I definitely don't
>>> still have that window open.
>>
>> OK, so I believe the attached patch fixes this, though I'm slightly
>> nervous about unintended side-effects. I'll provide Thom with a binary
>> for testing, but would appreciate it if someone else (Guillaume?)
>> could also review the patch.
>>
>
> Seems good to me. I don't find any side-effects on this patch. So +1 to
> commit it.
Thanks!
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | r d | 2010-10-07 18:32:06 | Small bug: COLUMN dialog types list wrong behavior |
Previous Message | Guillaume Lelarge | 2010-10-07 15:59:46 | Re: PgAdmin III 1.12 crazy memory usage |