From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: ctlCombobox SetEditable to false on Linux |
Date: | 2010-09-28 04:59:40 |
Message-ID: | AANLkTikYJMZcaqW+JfXjFp+xSonLgr0aA1xPaR5YvLPU@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Guillaume,
Auto-completion functionality does not behave as expected on linux with GTK.
Hence, we disabled editing combo-box on GTK only.
Try & check if you can do something about it.
I gave a little try on it, but it did not go well for me because of lack of
expertise and time constraint. :-(
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company<http://www.enterprisedb.com>
*http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
On Tue, Sep 28, 2010 at 3:01 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info>wrote:
> Could I get rid of it?
>
> I probably need to explain a bit more (can't do less obviously :) ).
>
> I don't get what workaround it tries to achieve, but I definitely do get
> what advantages we would have on linux if we get rid of that three lines
> of code.
>
> What I would like to do is get rid of this:
>
> #ifdef __WXGTK__
> SetEditable(false);
> #endif
>
> starting at line 176, on file ctlComboBox.cpp, and commit the patch. I
> would then be able to see if I find any issues, even when I'm working on
> other patches. If I can't do this, I actually don't know how I can find
> that. Of course, I could modify that on my git repositories, but it's
> dangerous: it could get commited without me noticing it.
>
> So, any objection?
>
>
> --
> Guillaume
> http://www.postgresql.fr
> http://dalibo.com
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2010-09-28 05:34:17 | Re: ctlCombobox SetEditable to false on Linux |
Previous Message | Guillaume Lelarge | 2010-09-27 21:31:36 | ctlCombobox SetEditable to false on Linux |