Re: [COMMITTERS] pgsql: Include the backend ID in the relpath of temporary relations.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Include the backend ID in the relpath of temporary relations.
Date: 2010-08-13 22:58:04
Message-ID: AANLkTikUreb=K8LvtLh3gvJTDi8DDXCSAENOd3PRocMv@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Aug 13, 2010 at 6:38 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Aug 13, 2010 at 5:51 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> rhaas(at)postgresql(dot)org (Robert Haas) writes:
>>> Include the backend ID in the relpath of temporary relations.
>>
>> A couple of the buildfarm members don't like this patch.  I think you
>> missed making some edits in some dtrace calls.
>
> Well, I guess that's why we have a buildfarm.  Working on it now...

I have taken a crack at fixing this but someone who understands DTrace
better than I do may want to check and see if the changes look sane.
It appears to me that we have no documentation - not even so much as a
source code comment - explaining how these probes are supposed to work
or what the arguments to each one are intended mean. That may not be
ideal.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-08-13 23:23:14 Re: Re: [COMMITTERS] pgsql: Include the backend ID in the relpath of temporary relations.
Previous Message Robert Haas 2010-08-13 22:54:17 pgsql: Fix assorted dtrace breakage caused by patch to include backend

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-08-13 23:23:14 Re: Re: [COMMITTERS] pgsql: Include the backend ID in the relpath of temporary relations.
Previous Message Robert Haas 2010-08-13 22:38:29 Re: pgsql: Include the backend ID in the relpath of temporary relations.