From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Florian Pflug <fgp(at)phlo(dot)org>, Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq. |
Date: | 2010-06-25 13:15:18 |
Message-ID: | AANLkTikMo-t5XLnbbF84tDfKZSaZ5UzKDoE00LdakuYi@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Thu, Jun 24, 2010 at 11:50 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Thu, Jun 24, 2010 at 1:38 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>> On Thu, 2010-06-24 at 11:15 -0400, Tom Lane wrote:
>>>> It might be a good idea to add a sentence to the documentation, though,
>>>> just pointing out that these control client-side keepalive probes rather
>>>> than server-side.
>>>
>>> Yes please. I was confused; I think others will be also.
>
>> Do either of you have any thoughts about where would be the best place
>> to add such a sentence?
>
> In the hunk you added to libpq.sgml would be fine by me.
Well, the trick is that the hunk that I added is really four separate
sections, and adding a whole sentence to each one seems like overkill.
Here's an attempt at rewording the sections so that the information
is included in each parameter's description without taking up a whole
sentence.
Thoughts?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
Attachment | Content-Type | Size |
---|---|---|
libpq-keepalive-docs.patch | application/octet-stream | 3.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2010-06-25 13:34:25 | Re: pgsql: Add TCP keepalive support to libpq. |
Previous Message | Simon Riggs | 2010-06-25 13:11:25 | pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes. |
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2010-06-25 13:34:25 | Re: pgsql: Add TCP keepalive support to libpq. |
Previous Message | Simon Riggs | 2010-06-25 13:11:25 | pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes. |