From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: refactoring comment.c |
Date: | 2010-08-27 21:38:07 |
Message-ID: | AANLkTikJQfW9SKfreC=qhp7gxz8n88ONsbsL2pOQykz2@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Aug 27, 2010 at 5:35 PM, Kevin Grittner
<Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I suppose this is unhappy because it things elog(ERROR) might
>> return?
>
> It looks more like this code uses it without initialization:
>
> case OBJECT_INDEX:
> case OBJECT_SEQUENCE:
> case OBJECT_TABLE:
> case OBJECT_VIEW:
> relation =
> get_relation_by_qualified_name(objtype, objname,
> lockmode);
> address.classId = RelationRelationId;
> address.objectId = RelationGetRelid(relation);
> address.objectSubId = 0;
> break;
OK, I must be missing something. Go through that a little slower?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2010-08-27 21:40:31 | Re: refactoring comment.c |
Previous Message | Kevin Grittner | 2010-08-27 21:35:13 | Re: refactoring comment.c |