Re: [COMMITTERS] pgsql: Allow copydir() to be interrupted.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: [COMMITTERS] pgsql: Allow copydir() to be interrupted.
Date: 2010-07-02 15:07:10
Message-ID: AANLkTikD7RsSgt9D5ue4ZqBg75HenAMxR0BkXmy9ZKKz@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Jul 2, 2010 at 10:21 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Jul 2, 2010 at 10:18 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>>>> This appears to have broken MinGW and Cygwin builds on the buildfarm.
>>>
>>> Well, that's not awesome. IM-ing with Magnus now.  I'm wondering if
>>> this is a link-ordering problem of some kind.
>>
>> Possibly an #ifndef FRONTEND will fix it.
>
> What's failing to link is postgres.exe

I suspect that moving copydir.c into the backend will fix this, but I
don't have an appropriate build environment to test. Can someone
please test the attached patch?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

Attachment Content-Type Size
copydir-to-backend.patch application/octet-stream 14.8 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-07-02 16:38:56 Re: [COMMITTERS] pgsql: Allow copydir() to be interrupted.
Previous Message Robert Haas 2010-07-02 14:21:05 Re: pgsql: Allow copydir() to be interrupted.

Browse pgsql-hackers by date

  From Date Subject
Next Message Nasby, Jim 2010-07-02 15:11:41 Re: Bug / shortcoming in has_*_privilege
Previous Message Robert Haas 2010-07-02 14:21:05 Re: pgsql: Allow copydir() to be interrupted.