| From: | Magnus Hagander <magnus(at)hagander(dot)net> | 
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> | 
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chris Travers <chris(at)metatrontech(dot)com>, Cristian Bittel <cbittel(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> | 
| Subject: | Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session | 
| Date: | 2010-08-24 19:10:25 | 
| Message-ID: | AANLkTik9JaGK1AysdqTkx=iNiVcaEBy4-CBS8P4BYXza@mail.gmail.com | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers | 
On Tue, Aug 24, 2010 at 15:58, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>> Robert Haas wrote:
>>> Yeah, that seems very plausible, although exactly how to verify I don't know.
>
>> And here is confirmation from the Microsoft web site:
>
>>       In some instances, calling GetExitCode() against the failed process
>>       indicates the following exit code:
>>       128L ERROR_WAIT_NO_CHILDREN - There are no child processes to wait for.
>
> Given the existence of the deadman switch mechanism (which I hadn't
> remembered when this thread started), I'm coming around to the idea that
> we could just treat exit(128) as nonfatal on Windows.  If for some
> reason the child hadn't died instantly at startup, the deadman switch
> would distinguish that from the case described here.
Just because I had written it before you posted that, here's how the
win32-specific-set-a-flag-when-we're-in-control thing would look. But
if we're convinced that just ignoring error 128 is safe, then that's
obviously a simpler patch..
-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/
| Attachment | Content-Type | Size | 
|---|---|---|
| win32_early_death.patch | application/octet-stream | 8.8 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-08-24 19:14:14 | Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session | 
| Previous Message | Alvaro Herrera | 2010-08-24 17:17:59 | Re: BUG #5627: Can not install on POSReady 2009 | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-08-24 19:14:14 | Re: [BUGS] BUG #5305: Postgres service stops when closing Windows session | 
| Previous Message | Bruce Momjian | 2010-08-24 19:07:22 | Re: Backups from the standby (Incrementally Updated Backups), open item |