From: | Greg Stark <gsstark(at)mit(dot)edu> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Colin 't Hart" <colinthart(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: What happened to the is_<type> family of functions proposal? |
Date: | 2010-09-21 17:45:12 |
Message-ID: | AANLkTik8FBMYDU=EcM83SGbaYx7rjds3tXZY5urxVgoO@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Sep 21, 2010 at 6:02 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> So we could refactor the input functions so that there's an internal
> function that returns the accepted datum in the OK case and an ErrorData
> for the failure case. The regular input function would just throw the
> error data in the latter case; but this would allow another function to
> just return whether it worked or not.
You're assuming the input function won't have any work it has to undo
which it would need the savepoint for anyways. For most of the
built-in datatypes -- all of the ones intended for holding real data
-- that's true. But for things like regclass or regtype it might not
be and for user-defined data types.... who knows?
Of course all people really want is to test whether something is a
valid integer, floating point value, etc.
--
greg
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-09-21 17:46:33 | Re: .gitignore files, take two |
Previous Message | Robert Haas | 2010-09-21 17:43:28 | Re: Git conversion status |