Re: WIP: Triggers on VIEWs

On 7 September 2010 08:43, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
> On 7 September 2010 02:03, David Christensen <david(at)endpoint(dot)com> wrote:
>>
>> On Sep 5, 2010, at 3:09 AM, Dean Rasheed wrote:
>>
>>> On 15 August 2010 18:38, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>>>> Here is a WIP patch implementing triggers on VIEWs ... <snip>
>>>>
>>>> There are still a number of things left todo:
>>>>  - extend ALTER VIEW with enable/disable trigger commands
>>>>  - much more testing
>>>>  - documentation
>>>>
>>>
>>> Attached is an updated patch with more tests and docs, and a few minor
>>
>>
>> At least for me, there are some portions of the docs which could use some formatting changes in order to not be confusing grammatically; e.g., this was confusing to me on the first read:
>>
>> -    trigger name.  In the case of before triggers, the
>> +    trigger name.  In the case of before and instead of triggers, the
>>
>> I realize this lack of formatting was inherited from the existing docs, but this would make more sense to me if this (and presumably the other related instances of "before" and "after") were set apart with <literal></> or similar.  This is already in use in some places in this patch, so seems like the correct markup.
>>
>
> Yeah, I think you're right. That chapter is the first place in the
> manual where the concepts of before/after/instead of are introduced.
> The first time it mentions them it uses <firstterm>, but then it
> doesn't use any markup for them for the remainder of the chapter. It
> looks like the rest of the manual uses <literal>+uppercase wherever
> they're mentioned, which does help readability, so it would make sense
> to bring the rest of that chapter into line with that convention.
>
> Thanks for looking at this.
>
> Cheers,
> Dean
>

Here's an updated version with improved formatting and a few minor
wording changes to the triggers chapter.

Regards,
Dean