| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
| Cc: | Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, Steve Singer <ssinger(at)ca(dot)afilias(dot)info>, Steve Singer <ssinger_pg(at)sympatico(dot)ca>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to add a primary key using an existing index |
| Date: | 2010-11-29 01:40:08 |
| Message-ID: | AANLkTi=xA+JyEHukcTC_EFUYs7_jiryrS6YEaZS5+Efg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 28, 2010 at 8:06 PM, Itagaki Takahiro
<itagaki(dot)takahiro(at)gmail(dot)com> wrote:
> On Fri, Nov 26, 2010 at 05:58, Steve Singer <ssinger(at)ca(dot)afilias(dot)info> wrote:
>> The attached version of the patch gets your regression tests to pass.
>> I'm going to mark this as ready for a committer.
>
> I think we need more discussions about the syntax:
> ALTER TABLE table_name ADD PRIMARY KEY (...) WITH (INDEX='index_name')
Why not:
ALTER TABLE table_name ADD PRIMARY KEY (...) INDEX index_name;
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-11-29 01:43:34 | Re: [GENERAL] column-level update privs + lock table |
| Previous Message | Robert Haas | 2010-11-29 01:34:09 | Re: profiling connection overhead |