| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause, |
| Date: | 2011-02-15 02:06:22 |
| Message-ID: | AANLkTi=wp09PxfAT=gKH4bYgySZyPo_0R5pm5QTEXR-z@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Feb 15, 2011 at 9:21 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Wed, 2011-02-09 at 15:22 +0900, Fujii Masao wrote:
>
>> On the second thought, I think it's useful to emit the NOTICE message when
>> recovery reaches the pause point, as follows.
>>
>> NOTICE: Recovery will not complete until pg_xlog_replay_resume() is called.
>
> I'm OK with adding a message, but NOTICE is the wrong level.
>
> My proposal is this message
>
> LOG: Recovery has paused. Execute pg_xlog_replay_resume() to continue.
I agree to use LOG level. But "Execute pg_xlog_replay_resume() to continue."
looks like a hint rather than log. So what about:
LOG: Recovery has paused.
HINT: Execute pg_xlog_replay_resume() to continue.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2011-02-15 02:07:54 | Re: Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause, |
| Previous Message | Tom Lane | 2011-02-15 02:01:21 | pgsql: Rethink naming of contrib/intagg extension. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2011-02-15 02:07:54 | Re: Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause, |
| Previous Message | Tom Lane | 2011-02-15 01:42:40 | Re: [HACKERS] "Extension" versus "module" |