From: | Merlin Moncure <mmoncure(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl> |
Subject: | Re: patch (for 9.1) string functions |
Date: | 2010-07-26 13:10:06 |
Message-ID: | AANLkTi=h2wGYM1y6D8_7HX=tugtKaFasg6=gDnWBKpaZ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jul 26, 2010 at 8:02 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Regardless of where this function ends up, the concat_ws documentation
> should contain some mention of the fact that "ws" is intended to mean
> "with separator",
big +1 on that -- I've been loosely following the thread and I had
assumed 'ws' meant 'wide string' all this time :-).
> Come to think of it, have we checked that the behavior of LEFT, RIGHT,
> REVERSE, etc. is the same on other DBs, especially as far as nulls,
> empty strings, too-large or negative subscripts, etc is concerned?
Probably 'standard' behavior wrt null would be to be strict; return
null if any argument is null. The proposed behavior seems ok though.
> CONCAT('foo', NULL) => 'foo' really the behavior that everyone else
> implements here? And why does CONCAT() take a variadic "ANY"
> argument? Shouldn't that be variadic TEXT?
What does that accomplish, besides forcing you to sprinkle every
concat call with text casts (maybe that's not a bad thing?)?
merlin
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2010-07-26 13:26:05 | Re: patch (for 9.1) string functions |
Previous Message | Robert Haas | 2010-07-26 12:52:46 | Re: dynamically allocating chunks from shared memory |