From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Tatsuhito Kasahara <kasahara(dot)tatsuhito(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: memory leaks? using savepoint |
Date: | 2010-12-22 07:58:29 |
Message-ID: | AANLkTi=UHnYVzaJLR+Uqwr_kvttD2jaAHhCWJOn_P0nf@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Wed, Dec 22, 2010 at 3:24 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Dec 22, 2010 at 11:48 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
>>> The proposed patch looks very simple. I don't think that applying that
>>> patch will cause serious risk.
>>
>> Maybe so, maybe not, but *it won't get tested* to any meaningful degree
>> if it's applied.
>
> Umm.. I don't have good idea about this. Spend a lot time on the review?
The proposed patch changes only CopySnapshot in exec_simple_query.
But exec_bind_message seems to have the same problem. It calls
CopySnapshot on PortalHeapMemory, but calls FreeSnapshot on
MessageContext. Am I missing something?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Maxim Boguk | 2010-12-22 21:53:45 | Re: BUG #5798: Some weird error with pl/pgsql procedure |
Previous Message | Fujii Masao | 2010-12-22 06:24:47 | Re: memory leaks? using savepoint |