Re: Extensions and custom_variable_classes

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL-Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extensions and custom_variable_classes
Date: 2010-12-20 16:47:45
Message-ID: AANLkTi=QttGKwfi3gyR6BjLUQ9wD98DKsm-3RUduxdG1@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 20, 2010 at 11:36 AM, Dimitri Fontaine
<dimitri(at)2ndquadrant(dot)fr> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> The effect of that has to be that the postmaster adds a certain amount
>> of space to PostgreSQL's initial shared memory allocation.  That means
>> the postmaster has to know that pg_stat_statements is a valid custom
>> variable class.
>
> Ah. Yes. Indeed. So you still needed to edit postgresql.conf in such
> cases. Well there's only 1 contrib module that touches SHM, but is also
> happen to be the only one that needs custom_variable_classes support…
>
> Meanwhile, the custom_variable_classes related code has been removed
> from the extension's git branch, and the WITH ENCODING option is no more
> (the control file encoding is still there and defaults to UTF-8).
>
> Will continue collecting improvements ideas and cleanup needs as we go,
> unless you prefer to see new patches (they are easy enough to produce).
>
>  http://git.postgresql.org/gitweb?p=postgresql-extension.git;a=shortlog;h=refs/heads/extension

Patches are better for me, anyway...

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-12-20 16:54:19 Re: serializable lock consistency
Previous Message Dimitri Fontaine 2010-12-20 16:36:04 Re: Extensions and custom_variable_classes