Re: READ ONLY fixes

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: READ ONLY fixes
Date: 2011-01-21 04:13:48
Message-ID: AANLkTi=J+pGGwvrk496AAh_7PKx=JTOrnoJ=nmRWfKNz@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jan 16, 2011 at 6:58 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> I found the following message somewhat confusing:
> ERROR:  read-only property must be set before any query

I think what we need here is two messages, this one and a similar one
that starts with "read-write property...".

> When a subtransaction has set the mode more stringent than the
> top-level transaction did, that setting is reversed when the
> subtransaction ends (whether by success or by rollback), which was
> discussed as the desired behavior.  But the included regression tests
> do not exercise that case by testing the case where a SAVEPOINT is
> either rolled back or released.  Should those tests be included?

+1.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-01-21 04:24:40 Re: Error code for "terminating connection due to conflict with recovery"
Previous Message Robert Haas 2011-01-21 04:03:33 Re: READ ONLY fixes