Step ordering pgAgent

From: Jasmin Dizdarevic <jasmin(dot)dizdarevic(at)gmail(dot)com>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: Step ordering pgAgent
Date: 2010-12-31 14:38:25
Message-ID: AANLkTi=Gen+gjF-7vqEicFKK5dr1jH5kKwkg2k+doRw+@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,
I'm starting another thread for this topic. You'll find the last comment
from Dave at the bottom.

> 1. Step ordering
> I suggest adding a column named "jstorder" to pgagent.pga_jobsteps, so
> we don't have to rename the steps "A_", "B_" if an ordering is required.
In
> the GUI we would add an integer field to the "Change Step" mask.

> Hi,
> I'm not so keen on that - it could require some funky code to ensure
> that the user uses sequential (or at least, non-duplicate) numbers
> across all steps and would be a pain to upgrade to. Plus, there is
> precedence for using alpha ordering - that's how triggers work

>> I don't think that we must ensure that no duplicate values are used. With
>> changing the "order by jstname,jstid" clause to "order by
>> jstorder,jstname,jstid" we would have a fall back on alpha ordering.
>> Steps with "jstorder" = null would be executed last - so there is no need
to
>> upgrade. To give the user feedback about ordering in pgadmin, the steps
>> could be ordered the same way in tree view and steps tab in job
properties
>> dialog. We could also add the jstorder-column to the list view.

What do others think? I'm still not convinced this is necessary - and
it certainly will become inconsistent with triggers.

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-12-31 14:46:01 Re: code.pgadmin.org
Previous Message Magnus Hagander 2010-12-31 14:27:04 Re: Support for unlogged tables