Re: renaming contrib. (was multi-platform, multi-locale regression tests)

From: Marko Kreen <markokr(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marti Raudsepp <marti(at)juffo(dot)org>, Aidan Van Dyk <aidan(at)highrise(dot)ca>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, peter_e(at)gmx(dot)net, pgsql-hackers(at)postgresql(dot)org
Subject: Re: renaming contrib. (was multi-platform, multi-locale regression tests)
Date: 2010-11-11 20:15:54
Message-ID: AANLkTi=Duxx06tUnrmh2VOwnnOOOmAdMt_mMZtzyFVne@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 11, 2010 at 6:08 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Marti Raudsepp <marti(at)juffo(dot)org> writes:
>> On Thu, Nov 11, 2010 at 17:24, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Given that we have, in fact, never renamed any files in the history of
>>> the project, I'm wondering exactly why it thinks that the number of
>>> potential rename/copy targets isn't zero.
>
>> Because git doesn't do "rename tracking" at all -- a rename operation
>> is no different from a delete+add operation. Instead it tracks how
>> lines of code move around in the tree:
>> https://git.wiki.kernel.org/index.php/GitFaq#Why_does_git_not_.22track.22_renames.3F
>
> Hmmm ... so rename tracking is O(N^2) in the total number of patches
> applied, or lines patched, or some such measure, between the branches
> you're trying to patch between?  Ugh.  Doesn't sound like something
> we want to grow dependent on.

No, it's dependant on files changed between two trees.

It does not analyze history when doing rename tracking.

Default limit is 200. It should be easy to calculate whats needed for Postgres.

--
marko

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2010-11-11 20:19:47 Re: improved parallel make support
Previous Message Alvaro Herrera 2010-11-11 20:08:06 Re: MULTISET and additional functions for ARRAY