From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | walsender parser patch |
Date: | 2011-01-10 19:46:54 |
Message-ID: | AANLkTi=Aw1gT9X88AxjgxpuRYaGVXgh+3sc-q=n97A5m@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Attached is an updated version of Heikki's patch to use a parser for
the walsender commands, instead of parsing things manually. It also
does some minor refactoring in walsender.c to break out
IdentifySystem() and StartReplication() to their own functions to make
it more readable.
While having an actual parser here isn't *necessary* at this point, it
makes things easier. And it will become increasingly useful as we add
new features (for example, the "include all wal files" option for
streaming base backup, and I'm sure that sync rep will require some
additional commands or changes to commands).
Any objections to doing this?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
Attachment | Content-Type | Size |
---|---|---|
repl_parser.patch | text/x-patch | 26.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Joel Jacobson | 2011-01-10 19:56:44 | Re: Bug in pg_describe_object (was: Re: [HACKERS] obj_unique_identifier(oid)) |
Previous Message | Andreas Karlsson | 2011-01-10 19:38:50 | Bug in pg_describe_object (was: Re: [HACKERS] obj_unique_identifier(oid)) |