From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Noah Misch <noah(at)leadboat(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, pgsql-hackers(at)postgresql(dot)org, hanada(at)metrosystems(dot)co(dot)jp |
Subject: | Re: SQL/MED - file_fdw |
Date: | 2011-02-11 16:31:16 |
Message-ID: | AANLkTi=5coHzHv=+-PgmHxZhn3TqvHTSX9SszbvpcE2O@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Feb 12, 2011 at 01:12, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Feb 9, 2011 at 2:03 AM, Noah Misch <noah(at)leadboat(dot)com> wrote:
>> From a functional and code structure perspective, I find this ready to commit.
>> (I assume you'll drop the XXX: indent only comments on commit.) Kevin, did you
>> want to do that performance testing you spoke of?
>
> OK, so is this Ready for Committer, or we're still working on it?
Basically, we have no more tasks until the FDW core API is applied.
COPY API and file_fdw patches are waiting for it.
If we extend them a little more, I'd raise two items:
* Should we print foreign table names in error messages?
http://archives.postgresql.org/pgsql-hackers/2011-02/msg00427.php
* COPY encoding patch was rejected, but using client_encoding is
logically wrong for file_fdw. We might need subset of the patch
for file_fdw.
--
Itagaki Takahiro
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2011-02-11 16:33:23 | Re: Add support for logging the current role |
Previous Message | Kevin Grittner | 2011-02-11 16:31:08 | Re: SQL/MED - file_fdw |