Re: rollback to savepoint leads to transaction already in progress

From: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
To: David Newall <postgresql(at)davidnewall(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: rollback to savepoint leads to transaction already in progress
Date: 2010-10-14 08:36:49
Message-ID: AANLkTi=57XG-UX3ve3XOi_Mi62nQ3P+s_bbrQmwO1oMd@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, Oct 14, 2010 at 3:52 PM, David Newall
<postgresql(at)davidnewall(dot)com> wrote:
> This does seem to be an new bug in previously working code.  While any
> solution that fixes the problem is good, it might pay to look the code that
> worked before.  As reported, it worked for ecpg (PostgreSQL 8.3.8) 4.4.1.

It works on 8.3, but it's still broken. Here is the code in 8.3.
It ignores "ROLLBACK TO savepoint", but also ignores "ROLLBACK TRANSACTION".

----
if (strcmp(transaction, "commit") == 0 || strcmp(transaction, "rollback") == 0)
con->committed = true;
else
con->committed = false;
----

--
Itagaki Takahiro

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Meskes 2010-10-14 10:53:08 Re: rollback to savepoint leads to transaction already in progress
Previous Message David Newall 2010-10-14 06:52:25 Re: rollback to savepoint leads to transaction already in progress

Browse pgsql-hackers by date

  From Date Subject
Next Message Boszormenyi Zoltan 2010-10-14 09:56:24 Re: ECPG FETCH readahead
Previous Message Dean Rasheed 2010-10-14 07:39:15 Re: WIP: extensible enums