Re: pg_receivexlog and replication slots

> Actually I came up with the same need as Magnus, but a bit later, so...
> Attached is a patch to support physical slot creation and drop in
> pg_receivexlog with the addition of new options --create and --drop. It
> would be nice to have that in 9.4, but I will not the one deciding that
> at the end :) Code has been refactored with what is already available
> in pg_recvlogical for the slot creation and drop.

I think that create/drop options of a slot is unnecessary.
It is not different from performing pg_create_physical_replication_slot() by psql.

At consistency with pg_recvlogical, do you think about --start?

Initial review.

The patch was not able to be applied to the source file at this morning time.

commit-id:5ff5bfb5f0d83a538766903275b230499fa9ebe1

[postgres postgresql-5ff5bfb]$ patch -p1 < 20140812_physical_slot_receivexlog.patch
patching file doc/src/sgml/ref/pg_receivexlog.sgml
patching file src/bin/pg_basebackup/pg_receivexlog.c
Hunk #2 FAILED at 80.
1 out of 7 hunks FAILED -- saving rejects to file src/bin/pg_basebackup/pg_receivexlog.c.rej
patching file src/bin/pg_basebackup/pg_recvlogical.c
patching file src/bin/pg_basebackup/streamutil.c
patching file src/bin/pg_basebackup/streamutil.h

The patch was applied to the source file before August 12.
warning comes out then make.

commit-id:6aa61580e08d58909b2a8845a4087b7699335ee0

[postgres postgresql-6aa6158]$ make > /dev/null
streamutil.c: In function ‘CreateReplicationSlot’:
streamutil.c:244: warning: suggest parentheses around ‘&&’ within ‘||’

Regards,

--
Furuya Osamu