Re: Adding packages fro WAL-G and Odyssey

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: pgsql-pkg-debian(at)postgresql(dot)org
Subject: Re: Adding packages fro WAL-G and Odyssey
Date: 2021-12-06 07:09:55
Message-ID: A8A5F8DD-F9A8-4407-9381-815C4B54A8E6@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-pkg-debian

> 5 июля 2021 г., в 21:25, Christoph Berg <myon(at)debian(dot)org> написал(а):
>
> Re: Andrey Borodin
>>> we'd need a proper debian/ directory for these, either in the upstream
>>> repo or in a separate one.
>> Odyssey had debian/ dir https://github.com/yandex/odyssey/tree/master/scripts/debian
>
> Hi,
>
> that directory would need to be /debian, not somewhere deeper in the
> tree. (Interestingly, you already have a /debian, just with less
> files.)
>
>> WAL-G is simply one Go binary. https://github.com/wal-g/wal-g/tree/master/cmd/pg
>> Though it's a separate Go binary for each DB: PG, MySQL, MSSQL, MongoDB etc. But I think it's better to start from PG anyway.
>> We used to build this binary and create almost empty debian/ dir with a script (FPA). We can commit this dir it it's better to have it in source tree.
>
> FPA usually doesn't produce "proper" packages with a curated
> debian/changelog (no throwing away of old entries, and sensible log
> messages) and the other bits.
>
> debian/rules shouldn't try to build a -dbg package these days
>
> debian/control shouldn't depend on postgresql-server-dev-13 but on
> postgresql-server-dev-all if you really need server headers instead of
> just the client ones.
>
> The Description needs more content
>
> Standards-Version is outdated
>
> Consider using debhelper-compat (= 13) instead of debian/compat 9
>
> Consider providing a systemd .service file along the init script

Thanks, Christoph!
We have updated /debian stuff in Odyssey. Can you please take a look again?
https://github.com/yandex/odyssey/pull/372/files

Best regards, Andrey Borodin.

In response to

Browse pgsql-pkg-debian by date

  From Date Subject
Next Message apt.postgresql.org Repository Update 2021-12-06 07:21:50 omnidb updated to version 3.0.3b+ds-3.pgdg+1
Previous Message apt.postgresql.org Repository Update 2021-12-01 15:27:51 barman updated to version 2.17-1.pgdg+1