| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, king tomo <t(dot)katsumata1122(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18224: message bug in libpqwalreceiver.c. |
| Date: | 2023-12-12 10:20:31 |
| Message-ID: | A77339D2-D3C5-45EB-AA19-A6946F98DEC9@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
> On 10 Dec 2023, at 05:00, Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
>
> Hello Daniel,
>
> 05.12.2023 16:44, Daniel Gustafsson wrote:
>> Following the bouncing ball it turns out that restricting to 9.4+ (effectively
>> reapplying 083d29c65b78 adapted to the callsites moved to a common function)
>> across the board isn't doable since pg_basebackup requires IDENTIFY_SYSTEM for
>> 9.1->9.3 to get the starttli. Thus I opted for just fixing the error message
>> and left the restriction on 9.4+ as future work for when it can be done across
>> all callers.
>
> Isn't IDENTIFY_SERVER a mistake in the comment added?:
>
> + * IDENTIFY_SERVER returns 3 columns in 9.3 and earlier, and 4 columns in
> + * 9.4 and onwards.
Ugh, yes, fixing.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2023-12-12 10:37:19 | Re: BUG #18240: Undefined behaviour in cash_mul_flt8() and friends |
| Previous Message | Richard Guo | 2023-12-12 09:50:27 | Re: BUG #18238: Cross-partitition MERGE/UPDATE with delete-preventing trigger leads to incorrect memory access |